-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editor): Indent on tabs in expression fields #9659
fix(editor): Indent on tabs in expression fields #9659
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, and it works as expected.
I'm not sure about the UX of this change. Before you could navigate through the node form with Tab. After this change you get trapped in the first expression input because Tab now controls indentation.
2 flaky tests on run #5364 ↗︎
Details:
cypress/e2e/5-ndv.cy.ts • 2 flaky tests
Review all test suite changes for PR #9659 ↗︎ |
✅ All Cypress E2E specs passed |
* master: fix: Fix typo with submitted (no-changelog) (#9662) refactor(core): Revamp crash recovery mechanism for main mode (#9613) fix(editor): Improve dragndrop of input pills with spaces (#9656) fix(editor): Indent on tabs in expression fields (#9659) fix(editor): Color node connections correctly in execution preview for nodes that have pinned data (#9669) fix(core): Fix optional chaining in continue on fail check (#9667) feat(OpenAI Node): Allow to select Image analyze model & improve types (#9660)
* master: feat(editor): Harmonize rendering of new-lines in RunData (#9614) refactor(editor): Fix remaining FE type check errors (no-changelog) (#9607) fix(editor): Remove template creds setup from workflow when copied (no-changelog) (#9673) refactor(editor): Stop expecting `null` execution status (no-changelog) (#9672) fix: Fix typo with submitted (no-changelog) (#9662) refactor(core): Revamp crash recovery mechanism for main mode (#9613) fix(editor): Improve dragndrop of input pills with spaces (#9656) fix(editor): Indent on tabs in expression fields (#9659) fix(editor): Color node connections correctly in execution preview for nodes that have pinned data (#9669) fix(core): Fix optional chaining in continue on fail check (#9667) feat(OpenAI Node): Allow to select Image analyze model & improve types (#9660)
Got released with |
Summary
singleLine
->blurOnTab
to match the new purposeRelated tickets and issues
Fixes ADO-1920
Review / Merge checklist
(no-changelog)
otherwise. (conventions)